From 0cc6a5f5c28777f27358153738176e6825c33387 Mon Sep 17 00:00:00 2001 From: neon <18559658+neonsolstice@users.noreply.github.com> Date: Sun, 5 Jul 2026 21:40:52 +0000 Subject: [PATCH] fix(reader): prevent crash when changing download folder Check if `updateShortcut` is defined on `folder_shortcuts` before calling it. Older versions of KOReader do not have this method, which causes a fatal crash when selecting a custom download folder. Closes #517 --- .../bookorbit.koplugin/bookorbit_catalog_download.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/koreader-plugin/bookorbit.koplugin/bookorbit_catalog_download.lua b/koreader-plugin/bookorbit.koplugin/bookorbit_catalog_download.lua index 394f11e65..970b59415 100644 --- a/koreader-plugin/bookorbit.koplugin/bookorbit_catalog_download.lua +++ b/koreader-plugin/bookorbit.koplugin/bookorbit_catalog_download.lua @@ -156,7 +156,8 @@ function CatalogDownload.install(Catalog) require("ui/downloadmgr"):new{ onConfirm = function(path) logger.dbg("BookOrbit: download folder set to", path) - if self._manager and self._manager.ui and self._manager.ui.folder_shortcuts then + if self._manager and self._manager.ui and self._manager.ui.folder_shortcuts + and self._manager.ui.folder_shortcuts.updateShortcut then self._manager.ui.folder_shortcuts:updateShortcut("download_dir", path) end G_reader_settings:saveSetting("download_dir", path)