Migrations/bookorbit
1
0
Fork 0
mirror of https://github.com/bookorbit/bookorbit.git synced 2026-11-03 00:11:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

test(client): type the recorded request bodies

Browse Source 
The new assertions read `apiMock.mock.calls[0][1].body` straight off an `unknown`, which vitest
runs happily and `vue-tsc` rejects. Read them through one typed helper instead.
This commit is contained in:
neon
2026-09-21 17:29:36 +00:00
parent d87312a8ca
commit 3bdd25e968
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/features/reader/shared/composables/useReaderSettings.test.ts
+9 -4
View File
@@ -5,6 +5,12 @@ import { CBX_READER_DEFAULTS, READER_GROUP_DEFAULTS, type PdfReaderSettings } fr
const apiMock = vi.hoisted(() => vi.fn<(...args: unknown[]) => Promise<unknown>>())
vi.mock('@/lib/api', () => ({ api: apiMock }))
/** The JSON body of a recorded `api()` call, so an assertion can read what was actually sent. */
function sentBody(call = 0): Record<string, unknown> {
const init = apiMock.mock.calls[call]?.[1] as RequestInit | undefined
return JSON.parse(String(init?.body ?? '{}')) as Record<string, unknown>
}
const toastMock = vi.hoisted(() => ({
success: vi.fn<(...args: unknown[]) => unknown>(),
}))
@@ -353,7 +359,7 @@ describe('useReaderSettings - updateBookSettings', () => {
s.updateBookSettings({ fontSize: 22 } as never)
expect(apiMock).toHaveBeenCalledWith(`/api/v1/reader/preferences/${BOOK_FILE_ID}`, expect.objectContaining({ method: 'PATCH' }))
expect(JSON.parse(apiMock.mock.calls[0][1].body)).toEqual({ set: { fontSize: 22 } })
expect(sentBody()).toEqual({ set: { fontSize: 22 } })
})
it('sends nothing when the patch is empty, because the server rejects an empty body', () => {
@@ -433,10 +439,9 @@ describe('useReaderSettings - updateDefaultSettings', () => {
s.updateDefaultSettings({ fontSize: 18 } as never)
expect(apiMock).toHaveBeenCalledWith('/api/v1/reader/defaults/epub', expect.objectContaining({ method: 'PATCH' }))
const body = JSON.parse(apiMock.mock.calls[0][1].body)
const body = sentBody()
expect(body).toEqual({ set: { fontSize: 18 } })
// The whole point: nothing another client owns rides along and overwrites it.
expect(body.set.themeName).toBeUndefined()
expect(body.settings).toBeUndefined()
})
@@ -662,7 +667,7 @@ describe('useReaderDefaultSettings - update', () => {
s.update({ fontSize: 22 } as never)
expect(apiMock).toHaveBeenCalledWith('/api/v1/reader/defaults/epub', expect.objectContaining({ method: 'PATCH' }))
expect(JSON.parse(apiMock.mock.calls[0][1].body)).toEqual({ set: { fontSize: 22 } })
expect(sentBody()).toEqual({ set: { fontSize: 22 } })
})
it('sends nothing when the patch is empty', () => {