Migrations/bookorbit
1
0
Fork 0
mirror of https://github.com/bookorbit/bookorbit.git synced 2026-11-03 00:11:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(cover): respect PDF crop box during extraction

Browse Source 
Render the visible page region so wraparound covers do not appear in generated thumbnails.

Fixes #1242
This commit is contained in:
neon
2026-09-02 00:18:51 +00:00
parent e3779c1d7e
commit 3f06d4eee9
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/modules/metadata/lib/pdf-cover.test.ts
+2 -2
View File
@@ -25,11 +25,11 @@ describe('extractPdfCover', () => {
mockMkdtemp.mockResolvedValue('/tmp/pdf-cover-abc');
});
it('extracts first-page jpeg bytes and always cleans up temp directory', async () => {
it('extracts the first-page crop box as jpeg bytes and always cleans up the temp directory', async () => {
const coverBytes = Buffer.from('cover-bytes');
mockExecFile.mockImplementation((file, args, callback) => {
expect(file).toBe('pdftoppm');
expect(args).toEqual(['-jpeg', '-singlefile', '-r', '150', '-f', '1', '-l', '1', '/books/test.pdf', '/tmp/pdf-cover-abc/cover']);
expect(args).toEqual(['-jpeg', '-singlefile', '-cropbox', '-r', '150', '-f', '1', '-l', '1', '/books/test.pdf', '/tmp/pdf-cover-abc/cover']);
callback?.(null, '', '');
return {} as never;
});
server/src/modules/metadata/lib/pdf-cover.ts
+1 -1
View File
@@ -11,7 +11,7 @@ export async function extractPdfCover(absolutePath: string): Promise<Buffer | nu
const outPrefix = join(tmpDir, 'cover');
try {
await execFileAsync('pdftoppm', ['-jpeg', '-singlefile', '-r', '150', '-f', '1', '-l', '1', absolutePath, outPrefix]);
await execFileAsync('pdftoppm', ['-jpeg', '-singlefile', '-cropbox', '-r', '150', '-f', '1', '-l', '1', absolutePath, outPrefix]);
return await readFile(`${outPrefix}.jpg`);
} finally {
await rm(tmpDir, { recursive: true, force: true });