Migrations/bookorbit
1
0
Fork 0
mirror of https://github.com/bookorbit/bookorbit.git synced 2026-11-03 00:11:37 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(kobo): deliver a changed cover to a Kobo that already has the book

Browse Source 
A Kobo downloads a cover only for a new entitlement, so a changed cover
sent as changed metadata left the book with a text-only cover until the
home screen fetched a small tile. Record the cover id on each device
snapshot row and re-announce the book when it moves; rows from before
the change learn it silently. Serve tile-size requests at a full-screen
size so the sleep screen never stretches a tile.
This commit is contained in:
neon
2026-10-17 04:03:34 +00:00
parent 2dca4bc85c
commit edfa20e19f
9 changed files with 24159 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/test/kobo-cover-identity.e2e-spec.ts
+9 -1
View File
@@ -40,6 +40,7 @@ describe('Kobo cover image identity (e2e)', { timeout: 180_000 }, () => {
let device!: KoboDevice;
let entitlementId!: string;
let coverIdHeldByDevice!: string;
let lastDeliveredAs: Array<keyof SyncEntry> = [];
async function sync(syncToken?: string): Promise<{ entries: SyncEntry[]; hasMore: boolean; syncToken: string }> {
const response = await ctx.app.inject({
@@ -79,7 +80,11 @@ describe('Kobo cover image identity (e2e)', { timeout: 180_000 }, () => {
// A drained device is told nothing until something changes, so the id last delivered is the id
// the device is holding. Every test compares against that rather than re-syncing for it.
async function drainDelivered(): Promise<BookMetadata[]> {
const delivered = deliveredMetadata(await drainEntries());
const entries = await drainEntries();
const delivered = deliveredMetadata(entries);
lastDeliveredAs = entries.flatMap((entry) =>
(['NewEntitlement', 'ChangedProductMetadata'] as const).filter((kind) => entry[kind]?.BookMetadata.EntitlementId === entitlementId),
);
const last = delivered[delivered.length - 1];
if (last) coverIdHeldByDevice = last.CoverImageId;
return delivered;
@@ -216,6 +221,7 @@ describe('Kobo cover image identity (e2e)', { timeout: 180_000 }, () => {
expect(delivered[0]!.Title).toBe('Kobo Cover Identity, Revised');
expect(delivered[0]!.Publisher?.Name).toBe('Repro Press');
expect(delivered[0]!.CoverImageId).toBe(coverIdBefore);
expect(lastDeliveredAs).toEqual(['ChangedProductMetadata']);
expect(await thumbnailStatus(coverIdBefore)).toBe(200);
});
@@ -277,6 +283,8 @@ describe('Kobo cover image identity (e2e)', { timeout: 180_000 }, () => {
const delivered = await drainDelivered();
expect(delivered).toHaveLength(1);
expect(delivered[0]!.CoverImageId).not.toBe(coverIdBefore);
// A Kobo downloads a cover only for a new entitlement; as changed metadata it would show text.
expect(lastDeliveredAs).toEqual(['NewEntitlement']);
const [row] = await ctx.db
.select({ coverUpdatedAt: schema.bookMetadata.coverUpdatedAt })