mirror of
https://github.com/bookorbit/bookorbit.git
synced 2026-11-03 00:11:37 -06:00
neon
9b274cbae0
* fix(kobo): stop offering plugin updates to devices that crash applying them Plugin 1.3.x calls Device:unpackArchive, which KOReader removed in koreader/koreader@751b4978 (July 2026). The call is unguarded and the whole apply path runs without a pcall inside a ConfirmBox callback, so the missing method raises on UIManager's event loop and takes KOReader down. Plugin 1.4.0 fixed the extraction, but the broken updater is the code that would have to install that fix, so it can never self-deliver: every device still on 1.3.x crashes on every update attempt, forever. Gate the offer server side instead. GET /koreader/plugin/version now resolves the calling user and withholds pluginVersion when any of their devices last reported a plugin older than 1.4.0. Those clients already treat "unknown" as "the server could not tell me" and show a message rather than the update prompt, so the crashing path becomes unreachable without touching the plugin on the device. Two limits are inherent to a server-only mitigation and are not bugs. The endpoint carries no device id, only the user, so one stale device parks self-update for all of that user's devices until it is updated by hand or removed. A device that has never completed a sweep has no recorded version, so it is not gated. Neither is closable until the plugin reports its own version on the version check. Surface requiresManualUpdate per device in the KOReader settings so the affected devices say what to do, since the 1.3.x dialog string is baked into the installed plugin and cannot be changed from here. Closes #905 * fix(kobo): keep blank plugin versions inside the self-update gate A device reporting an empty pluginVersion produced a falsy blocker, so the truthiness check opened the gate and handed out the real version. The DTO allows an empty string, so this was reachable. Also move the settings spec fixtures above the manual-update cutoff, since a sub-1.4.0 version with requiresManualUpdate false describes a state that cannot occur.