refactor: standardize constant names and improve goroutine handling across multiple files.

server/internal/capture/screencast.go

@@ -87,11 +87,7 @@ func screencastNew(enabled bool, pipelineStr string) *ScreencastManagerCtx {
 		}),
 	}
 
-	manager.wg.Add(1)
-
-	go func() {
-		defer manager.wg.Done()
-
+	manager.wg.Go(func() {
 		ticker := time.NewTicker(screencastTimeout)
 		defer ticker.Stop()
 
@@ -105,7 +101,7 @@ func screencastNew(enabled bool, pipelineStr string) *ScreencastManagerCtx {
 				}
 			}
 		}
-	}()
+	})
 
 	return manager
 }
@@ -212,12 +208,9 @@ func (manager *ScreencastManagerCtx) createPipeline() error {
 		return errors.New("timeouted while waiting for first image")
 	}
 
-	manager.wg.Add(1)
 	pipeline := manager.pipeline
-
-	go func() {
+	manager.wg.Go(func() {
 		manager.logger.Debug().Msg("started receiving images")
-		defer manager.wg.Done()
 
 		for {
 			image, ok := <-pipeline.Sample()
@@ -228,7 +221,7 @@ func (manager *ScreencastManagerCtx) createPipeline() error {
 
 			manager.setImage(image)
 		}
-	}()
+	})
 
 	return nil
 }

server/internal/capture/streamsink.go

@@ -325,12 +325,9 @@ func (manager *StreamSinkManagerCtx) CreatePipeline() error {
 	manager.pipeline.AttachAppsink("appsink")
 	manager.pipeline.Play()
 
-	manager.wg.Add(1)
 	pipeline := manager.pipeline
-
-	go func() {
+	manager.wg.Go(func() {
 		manager.logger.Debug().Msg("started emitting samples")
-		defer manager.wg.Done()
 
 		for {
 			sample, ok := <-pipeline.Sample()
@@ -341,7 +338,7 @@ func (manager *StreamSinkManagerCtx) CreatePipeline() error {
 
 			manager.onSample(sample)
 		}
-	}()
+	})
 
 	manager.pipelinesCounter.Inc()
 	manager.pipelinesActive.Set(1)