Commit Graph

610 Commits

Author SHA1 Message Date
Kyungwook Park 6677f2f5ea feat(metadata): add Aladin Korean book metadata provider (#351)
* feat(metadata): add Aladin Korean book metadata provider

Add support for fetching Korean book metadata from Aladin OpenAPI.
Includes search by title/author/ISBN and lookup by ISBN-10/13.

- Add ALADIN to MetadataProviderKey in @bookorbit/types
- Add AladinProviderConfig to ProviderConfigurations
- Create AladinProvider with IdentifiableProvider interface
- Add mapper for Aladin API response to MetadataCandidate
- Register provider in MetadataFetchModule
- Add provider config merge, validation, and connection test
- Include 24 unit tests (provider + mapper)

* feat(client): add Aladin provider UI integration

* refactor(metadata): use 'Aladin' label and favicon-based icon

* feat(metadata): complete Aladin provider end-to-end wiring

Persist the Aladin ItemId across fetch, scoring, locks, and file metadata round-trip, and update the affected tests.

Co-authored-by: Kyungwook Park <288273+kyungw00k@users.noreply.github.com>

---------

Co-authored-by: neon <18559658+neonsolstice@users.noreply.github.com>
Co-authored-by: Kyungwook Park <288273+kyungw00k@users.noreply.github.com>
2026-06-17 13:33:35 -06:00
neon 9afddc34d2 feat(books): add support for multiple series per book
This introduces a many-to-many relationship between books and series, resolving the previous limitation where a book could only belong to a single series. It updates the database schema, query builders, server DTOs, and the Vue client interface to manage multiple series memberships per book.

Closes #353
2026-06-17 06:15:59 +00:00
neon 9b4408c610 fix(server): fix floating point precision in series index formatting
String/math based extraction of floating point series index fraction parts caused floating point precision artifacts. This extracts formatting into a shared utility and uses string splitting to avoid precision issues.

Closes #360
2026-06-17 05:36:48 +00:00
neon 86654bece8 fix(settings): add create link button to magic links admin tab
The "Create link" button was missing from the magic links admin tab because the header was hidden. This adds an embedded create action so the button is available when the component is rendered without a header.

Closes #357
2026-06-17 05:31:51 +00:00
neon 6eec39cb8a fix: allow resetting migration source setup
Add an API endpoint and UI action to reset the migration source configuration when no migration runs have been created yet.

Closes #354
2026-06-17 05:24:58 +00:00
neon a36a615b9a fix(client): add shift-click selection to entity manager
Add shift-click range selection in EntityBrowseTable to allow selecting multiple entities at once.

Closes #352
2026-06-17 05:13:05 +00:00
neon 7b48d49351 fix(server): accept empty requests with unsupported media types
Inject an empty JSON object for requests that have an unsupported content type but zero content length. Fastify defaults to rejecting these with a 415 error.

Closes #348
2026-06-17 05:07:44 +00:00
neon 0cddaf050c feat(metadata): add fallback scanner for EPUBs with missing ISBNs
Extract ISBNs from the EPUB spine contents if missing from the OPF metadata.

Closes #350
2026-06-15 23:24:56 +00:00
neon 671828d1b8 fix(client): restore shadow display for natural-bottom covers
The cover shadow moves to the inner artwork frame. The surface's own overflow:hidden would clip that shadow, so let it render by setting it to visible. The inner frame keeps its own overflow:hidden, so the image stays clipped to its rounded rect.

Closes #298
2026-06-15 16:27:47 +00:00
neon 96e42d2ac1 feat(settings): add option to turn book spine off for comics
Adds a display preference to conditionally render book spines on comic
formats. The new setting is defaulted to false. Various book cover
surfaces across the application now respect this preference by checking
if the format is a comic before rendering the spine.

Closes #295
2026-06-15 05:56:39 +00:00
neon f525c01a2f feat(query): add up-next in series filter operator
Adds the isUpNext operator to seriesStatus allowing books to be filtered by whether they are the next unread book in a series where the previous book is completed.

Closes #321
2026-06-15 04:58:31 +00:00
neon d13fc929e3 feat(metadata): support calibre 9.x opf3 metadata formats
Calibre 9.x (opf3) writes provider identifiers as bare `prefix:value` text
inside `<dc:identifier>` instead of using `opf:scheme` attributes. It also
stores custom-column values like page count and subtitle in a
`calibre:user_metadata` JSON blob. This adds parsing for these fallback
formats to correctly extract metadata from Calibre-processed EPUBs.

Closes #341
2026-06-15 04:26:27 +00:00
neon 1b8454f557 feat(stats): add device and rating achievement evaluators with session source tracking
Introduce devices and rating evaluators backed by a new reading_sessions.source
column, so badges can reward multi-device reading and book ratings. Wire the
source through Kobo and reading-session services and seed the new badges.
2026-06-15 04:03:54 +00:00
neon 49da34ee48 feat(server): add safe directory creation to path service
Introduces PathService.createDirectory with comprehensive path validation
to prevent directory traversal and symlink attacks. It validates parent paths
against a blocked list, ensures the parent is a real directory, and blocks
unsafe characters in folder names.

Filesystem errors like EEXIST and EACCES are mapped to standard HTTP
exceptions to provide clear feedback to the client.

Closes #332
2026-06-14 23:45:59 +00:00
neon 445bb39978 feat(books): add lock status to library filter rules
Closes #327
2026-06-14 23:33:44 +00:00
neon daa0001877 fix(metadata): prioritize physical hardcover editions over audiobooks
Rank physical and ebook editions higher than audiobooks in hardcover
metadata mapping. Do not allow audiobooks to inherit page counts from
the base book to prevent incorrect metadata.

Closes #334
2026-06-14 23:06:44 +00:00
neon dc82774291 fix(scanner): populate per-file audio duration on upload
The upload paths saved only the aggregate book_metadata duration, leaving book_files.durationSeconds
null so the player summed to zero. Extract and aggregate per-file duration on new uploads and added
audio files, matching the scanner.

Ref #330
2026-06-14 22:50:01 +00:00
James McNee f1b7254b86 fix(reader): totalBookDuration computation accounts for metadata duration when files lack duration data (#331)
Resolves: https://github.com/bookorbit/bookorbit/issues/330
2026-06-14 16:36:12 -06:00
neon 5d96ba1a55 fix(metadata): improve hardcover edition matching algorithm
The previous edition matching logic often resulted in suboptimal edition assignments, tracking text books against audiobooks or selecting editions with drastically different page counts. A more rigorous matching strategy is required to ensure users get accurate edition metadata from Hardcover.

Closes #333
2026-06-14 22:34:08 +00:00
neon 854dc55085 fix(books): prevent next-book navigation from sticking at boundaries
Fetch requests now await existing promises for in-flight blocks instead of re-triggering and starving the load when crossing block boundaries. The navigation window entries are also preserved during identical structural updates to avoid infinite watcher loops.

Closes #325
2026-06-14 21:40:59 +00:00
neon 007985a6d0 fix(client): move filter panels out of the scroll container
The Library, Series, and Authors filter panels were rendered inside the
scrolling <main> element, so opening a panel after scrolling down placed
it above the visible viewport and it appeared to do nothing until the
page was scrolled back to the top. Render each panel as a sibling of
<main> so it stays anchored regardless of scroll position. A height cap
is intentionally avoided because the filter typeaheads use absolutely
positioned dropdowns that an overflow container would clip.

Add structural regression tests for the Series and Authors views that
assert the panel renders outside the scroll container.

Fixes #326
2026-06-14 21:16:24 +00:00
neon 101c8d4cce fix(metadata): restore Goodreads fetching via autocomplete fallback when detail pages are WAF-gated 2026-06-14 20:19:15 +00:00
neon e3ee046dc5 fix(metadata): normalize zero page count to null to prevent save errors
When a metadata provider returns a page count of 0 (e.g. unknown), the frontend would submit 0, causing a validation error (HTTP 400). This change normalizes 0 to null on both the client (before sending) and server (during validation).

Closes #329
2026-06-14 07:13:01 +00:00
neon c7f3e8eacb fix(metadata): allow saving edits to re-locked metadata fields
Removes the `assertManualUpdateAllowedForLockTransition` guard that incorrectly rejected the legitimate UI flow of unlocking a field, editing its value, and re-locking it before saving.

Closes #328
2026-06-14 06:44:37 +00:00
Chris Mansell aed22712cc feat(metadata): add LubimyCzytac metadata provider (#324)
* feat(metadata): add LubimyCzytac metadata provider

- Add LubimyCzytac scraper and provider implementation
- Add lubimyczytacId field across types, schema, extractors, and metadata service
- Register lubimyczytac provider in module, pipeline, repository, and config service
- Add provider icon, color, link, and UI support in book detail views
- Add migration for lubimyczytac_id column

Closes #304

* fix(books): keep cover card read button opening reader when thumbnail click prefers details

The overlay primary button should always open the reader regardless of
the thumbnailClickAction setting. That setting only controls card click
behaviour.

* fix(books): add explicit read button to hover overlay when thumbnail click prefers details

When thumbnailClickAction is 'details', a dedicated Read button now
appears in the overlay top row so users can still open the reader
directly without changing their preference.
2026-06-13 11:40:53 -06:00
neon d42abb3647 fix(metadata): extract and save audiobook chapters and embedded metadata
The book dock metadata service now routes audio formats through the audio extractor to extract chapters, duration, narrators, and other embedded tags. This ensures that audiobook metadata is correctly mapped and persisted during the import process.

Closes #322
2026-06-13 17:18:40 +00:00
neon 702cb267ba fix(client): add enterkeyhint to ChipInput for mobile keyboards
Mobile keyboards, such as on Android, may not show a functioning
Enter key by default in this input. Adding enterkeyhint="enter"
allows users to properly submit chips like authors in the
metadata editor.

Closes #310
2026-06-13 16:54:41 +00:00
neon 873f890d20 fix(client): respect device orientation lock in pwa
The `orientation: 'any'` setting in the manifest forces the PWA to rotate even if the device is locked. Removing it restores native behavior.

Closes #309
2026-06-13 16:50:13 +00:00
neon 5aace0b49e feat(collections): reword message when adding an item to a collection
The previous 'already here' message was confusing when immediately adding an item to a collection, making it seem like the action didn't just occur. The confirmation has been updated to clarify that the item was just added.

Closes #306
2026-06-13 16:47:30 +00:00
neon a0e6850d69 refactor(books): remove bulk tags dialog and add individual edit action
The standalone BulkUpdateTagsDialog and its related state have been
removed from the table shell and views. In its place, a new
handleEditIndividually action was added, allowing users to select
multiple books and open the first one in the detail view for sequential
editing. The SelectionActionBar was also updated to support this action
and display query-scoped selection states.
2026-06-13 16:20:42 +00:00
neon b48dac0e30 refactor(books): update book window to use slots
Modify book navigation composables to work with sparse subsets
by pairing loaded book IDs with their absolute position in the
full listing. This ensures books reached via the jump rail
maintain their true position even when windowed.

Closes #319
2026-06-13 04:19:25 +00:00
neon 4f4189281c feat(books): support details preference in cover card overlay
When the user preference for thumbnail clicks is set to 'details', the
primary overlay button on book cards now routes to the book details
page and displays a BookText icon instead of the reader icon.

Also replaced the ExternalLink icon with BookText across dropdown
menus and settings for better visual consistency.
2026-06-12 18:40:09 +00:00
neon 5d0b5143fc fix(cover): resolve spine sizing and consistency issues
Delay spine layer rendering for blurred-fit covers until the image ratio is known so it does not overflow the artwork. Enable spine overlays on series stack cards, series detail headers, and carousels where they were previously disabled. Apply data attributes to spine layers so standalone artwork elements render properly without surface ancestors.

Closes #294
2026-06-12 05:43:12 +00:00
neon b81ba163ce fix(scanner): fallback to original filename when title is missing in patterns
The default upload file naming patterns for single file and folder per book previously relied exclusively on the title. If multiple files lacked a title, they would map to the same path. This changes the default patterns to fall back to the original filename if the title is missing, preventing files without metadata from clumping.

Closes #308
2026-06-12 05:27:59 +00:00
neon 280aad0712 refactor(books): replace cover loading placeholder with simple skeleton
Simplify the loading state for book covers by removing the complex BookCoverPlaceholder in favor of a neutral pulsing skeleton. This ensures a cleaner visual experience while the actual cover image is being loaded.
2026-06-12 05:20:38 +00:00
neon b1dff917ad feat(books): add jump rail navigation to book listings (#318)
Add server-backed jump buckets so large library, collection, and smart-scope listings can jump directly to sorted sections without loading every row up front.

Closes #163
2026-06-11 23:16:58 -06:00
neon 43e417b66e style(client): make edit metadata action buttons icon-only on narrow screens
Update the action buttons in the Edit Metadata tab to hide their text
labels on small screens. The buttons are kept horizontally scrollable on
mobile but wrap to the next line on desktop viewports. This ensures the
Save button and other actions are easily accessible without consuming
excessive vertical space on mobile devices.

Closes #292
2026-06-09 18:39:19 +00:00
neon c8401f2fa4 fix(reader): ignore keyboard shortcuts in shadow dom inputs
Keyboard events bubbling up from within a shadow DOM (such as the PDF
viewer's embedded find bar) report the custom element host as the event
target rather than the inner input field. This caused the reader's
global shortcuts to incorrectly trigger while typing.

Resolved by checking e.composedPath() to determine the true origin
of the event.

Closes #291
2026-06-09 18:18:21 +00:00
neon 9efd48c72b fix(reader): add floating back button to exit pdf viewer
The PDF reader lacked an exit button, trapping users. Since the native PDF viewer header is packed with tools and difficult to safely inject into, a floating action button (FAB) is added to the bottom left of the screen.

Closes #290
2026-06-09 18:08:49 +00:00
neon e07e3dac7b feat(books): add send via email action to details page
The details page now includes a 'Send via Email' button in the more options menu if the user has the email_send permission. Selecting it opens the SendBookDialog.

Closes #289
2026-06-09 03:10:50 +00:00
neon d9f3f31503 refactor(auth): split OidcCleanupService into service and job
Extract DB deletion logic into OidcCleanupService as a pure method
returning counts. Move the @Cron trigger, logging, and error handling
into a new OidcCleanupJob, matching the AuditCleanupJob pattern.
2026-06-08 22:53:44 +00:00
neon 69c09c5849 feat(metadata): import cover image from OPF sidecar guide and manifest
Sidecar OPF files can link to a sibling cover image, but the extractor
always passed null for the cover buffer, silently dropping the image.

Parse coverHref from three sources in priority order:
1. EPUB2 <guide><reference type="cover" href="..."/>
2. EPUB3 <manifest><item properties="cover-image" href="..."/>
3. Calibre <meta name="cover" content="id"/> resolved via manifest

Resolve the href relative to the OPF file directory and read the image
file. Fall back to null cover if the file is missing or unreadable,
so a broken cover link does not fail the import.

Closes #273
2026-06-08 22:27:00 +00:00
neon 058555b765 fix(auth): surface actionable error when OIDC issuer resolves to private address
The SSRF guard was throwing a generic 'URL host is not allowed' with no
indication that the block was due to a private or local IP, or how to
resolve it. Users with a LAN-hosted OIDC provider had no way to diagnose
the failure.

Introduce PrivateAddressException extends BadRequestException in ssrf.utils
so callers can distinguish private-address blocks from other validation
errors. The OIDC connection test catches it and re-throws with a message
that names OIDC_ALLOW_LOCAL_ISSUERS=true as the fix.

Closes #264
2026-06-08 22:00:36 +00:00
neon a1b417ccb8 chore(kobo): fix invalidateSnapshot log format and remove unbounded bookIds field
The debug log in invalidateSnapshot did not follow the project logging
convention ([event] [phase] key=value ... - message) and logged all
reset book IDs, which could produce unbounded single-line output for
large libraries.

Fix the event name, add the [end] phase marker, add durationMs, drop
the bookIds field, and remove the no-snapshot early-return log (noisy
no-op path).
2026-06-08 21:48:21 +00:00
Logan Selley 9de47fe67d fix(kobo): enhance kobodeviceservice to manage device snapshots (#277)
* fix(kobo): enhance kobodeviceservice to manage device snapshots

Refactor KoboDeviceService to include a syncService for invalidating user snapshots when devices are created or revoked. Update tests to verify snapshot invalidation behavior and ensure proper service instantiation. This change improves the synchronization process for user devices in the Kobo ecosystem.

* test(kobo): update device revocation tests for snapshot invalidation

Enhance the test cases for the KoboDeviceService's revokeDevice method to verify that the syncService's invalidateSnapshot is called correctly and that database deletion methods are invoked the expected number of times. This ensures accurate testing of device revocation behavior and snapshot management.

---------

Co-authored-by: Logan-Selley <logan@selleytech.com>
Co-authored-by: neon <18559658+neonsolstice@users.noreply.github.com>
2026-06-08 15:45:13 -06:00
neon a54108b97d fix(series): keep startup alive when series backfill fails (#271)
* fix(series): keep startup alive when series backfill fails

The series id backfill ran inside SeriesIdentityService.onModuleInit
without any error handling, so any failure rejected the lifecycle hook
and aborted NestApplication bootstrap, leaving the app unable to start.
On databases where the book_series unique arbiter index is missing or
unusable, the backfill INSERT ... ON CONFLICT throws and bricks startup.

Wrap the backfill in a guard so failures are logged and startup
continues, and surface the underlying driver error (Drizzle hides the
real cause behind its 'Failed query' wrapper) so the root DB issue is
diagnosable from logs.

Closes #270

* fix(series): resolve series backfill timeout on large libraries

The NodePg pool has statement_timeout: 30_000 ms, which is the right
guard for API queries but too aggressive for the one-time startup
backfill. On libraries with 100k+ books the bulk UPDATE against
book_metadata hits the limit before completing, leaving series_id
NULL for all books and repeating the timeout on every subsequent
restart.

Two changes:

1. Wrap the backfill in a transaction and issue SET LOCAL
   statement_timeout = 0 at the start. SET LOCAL scopes the change to
   this transaction only, so the pool timeout applies to every other
   query unchanged. The transaction also makes all three backfill
   statements atomic: previously a successful INSERT followed by a
   timed-out UPDATE left book_series populated but series_id still
   NULL everywhere.

2. Add a functional B-tree index on lower(btrim(series_name)) in
   book_metadata. The backfill UPDATE joins on that expression; without
   an index the planner falls back to a full sequential scan and hash
   join on every startup. With the index, subsequent startups use a
   nested-loop index scan that short-circuits immediately when no rows
   need updating.

Measured on 250k books: first migration completes without timeout;
subsequent startups finish the no-op check in ~150ms.

Closes #270
2026-06-08 15:32:11 -06:00
neon c0a7aef075 feat(books): add file upload UI to book detail files tab 2026-06-08 20:44:43 +00:00
neon 8bee4905bb feat(book): implement file rename and delete interactions
- Adds rename and delete file capabilities to Book Details > Files tab
- Automatically promotes a fallback file to primary upon deletion
- Refactors path update logic to correctly apply db folder path updates
- Ensures file type format badges in header search use global format colors
- Replaces legacy file property overrides with rename-only DTO

Closes #214
2026-06-08 14:36:29 -06:00
neon 638e5f15df fix: select format in findAllBookFiles 2026-06-08 05:42:08 +00:00
neon e62cb743ac fix(scanner): treat pt ## audiobook subfolders as part folders
The scanner disc directory pattern previously recognized cd, disc, disk, part, and side, but not pt. This caused Pt subfolders to be treated as separate books instead of being merged into the parent audiobook. This change adds pt as an accepted disc/part folder prefix.

Closes #262
2026-06-07 23:37:31 -06:00